Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumbs & Module page <> Project page interaction fixes #6165

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

vellip
Copy link
Collaborator

@vellip vellip commented Feb 27, 2025

Describe your changes

  1. Changes "Project overview" to "Kiezradar" in breadcrumbs where the change hasn't been made yet
  2. Removes the conditional display of the module page in breadcrumbs (since we now always show a project page and a module page)
  3. Changes links back to the module page to always lead to the module page, and not back to the project page in case it's a single-module project
  4. (fixed a test that started failing after running make mo)

fixes #6130

Tasks

  • PR name contains story or task reference
  • Steps to recreate and test the changes
  • Documentation (docs and inline)
  • Tests (including n+1 and django_assert_num_queries where applicable)
  • Changelog

…rview string in breadcrumb to "kiezradar" for consistency; change links that previously lead to the detail page (either project or module) to always lead to the module page
@vellip vellip force-pushed the pv-2025-02-breadcrumb-fixes branch from aa3ce48 to 7313a7d Compare February 27, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants